Horton

Re: Assertion failure while streaming toasted data

Dilip Kumar <dilipbalaut@gmail.com>

View thread View on postgr.es
From: Dilip Kumar <dilipbalaut@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-26T12:40:00Z
Lists: pgsql-hackers 
On Wed, May 26, 2021 at 5:28 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, May 26, 2021 at 1:47 PM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> >
> > On Wed, May 26, 2021 at 11:53 AM Dilip Kumar <dilipbalaut@gmail.com> wrote:
> > >
> > > On Wed, May 26, 2021 at 11:19 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > >
> >
> > >
> > > > I searched and didn't find any similar existing tests. Can we think of
> > > > any other way to test this code path? We already have one copy test in
> > > > toast.sql, isn't it possible to write a similar test here?
> > >
> > > I will check that and let you know.
> >
> > I have followed this approach to write the test.
> >
>
> The changes look good to me. I have made minor modifications in the
> comments, see attached. Let me know what do you think?

Your modification looks good to me.  Thanks!

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Fix assertion during streaming of multi-insert toast changes.