Horton

Re: Identify missing publications from publisher while create/alter subscription.

Dilip Kumar <dilipbalaut@gmail.com>

View thread View on postgr.es
From: Dilip Kumar <dilipbalaut@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Japin Li <japinli@hotmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Euler Taveira <euler@eulerto.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-05-07T06:20:23Z
Lists: pgsql-hackers 
On Thu, May 6, 2021 at 7:22 PM vignesh C <vignesh21@gmail.com> wrote:
>

Some comments:
1.
I don't see any change in pg_dump.c, don't we need to dump this option?

2.
+ /* Try to connect to the publisher. */
+ wrconn = walrcv_connect(sub->conninfo, true, sub->name, &err);
+ if (!wrconn)
+ ereport(ERROR,
+ (errmsg("could not connect to the publisher: %s", err)));

Instead of using global wrconn, I think you should use a local variable?

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Raise a WARNING for missing publications.