Horton

Re: Proposal: Conflict log history table for Logical Replication

Dilip Kumar <dilipbalaut@gmail.com>

View thread
From: Dilip Kumar <dilipbalaut@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: shveta malik <shveta.malik@gmail.com>, vignesh C <vignesh21@gmail.com>, Nisha Moond <nisha.moond412@gmail.com>, Peter Smith <smithpb2250@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, shveta malik <shvetamalik@gmail.com>
Date: 2026-05-31T06:02:51Z
Lists: pgsql-hackers 
On Thu, May 28, 2026 at 4:38 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, May 26, 2026 at 2:38 AM shveta malik <shveta.malik@gmail.com> wrote:
> >
> > 2)
> > drop_subscription_dependencies():
> >
> > + conflictrelname = get_rel_name(subconflictlogrelid);
> >
> > We can actually have a sanity check that we got the CLT using the relid.
> > Assert(conflictrelname != NULL);
> >
>
> elog will suit this place better as this can't be a direct coding
> mistake. I see that at other places we used elog. See
> if (result == NULL)
> elog(ERROR, "cache lookup failed for index %u", indexId);

Yes it make sense to report elog, I will change this.


-- 
Regards,
Dilip Kumar
Google