Re: Concurrency bug in UPDATE of partition-key
Dilip Kumar <dilipbalaut@gmail.com>
From: Dilip Kumar <dilipbalaut@gmail.com>
To: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-06-19T07:36:24Z
Lists: pgsql-hackers
On Mon, Jun 18, 2018 at 6:19 PM, Amit Khandekar <amitdkhan.pg@gmail.com> wrote: > On 18 June 2018 at 17:56, Amit Kapila <amit.kapila16@gmail.com> wrote: >> On Mon, Jun 18, 2018 at 11:28 AM, Dilip Kumar <dilipbalaut@gmail.com> wrote: >>> Should we also create a test case where we can verify that some >>> unnecessary or duplicate triggers are not executed? >>> >> >> I am not sure how much value we will add by having such a test. In >> general, it is good to have tests that cover various aspects of >> functionality, but OTOH, we have to be careful to not overdo it. > > Actually I am thinking, it's not a big deal adding a RAISE statement > in trigger function in the existing testcases. It will clearly show how > many times the trigger has executed. So I will go ahead and do that. Ok, That makes sense to me. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
Commits
-
Allow using the updated tuple while moving it to a different partition.
- 40ca70ebcc9d 12.0 landed
- 0527df732beb 11.0 landed