Re: Decoding speculative insert with toast leaks memory

Dilip Kumar <dilipbalaut@gmail.com>

From: Dilip Kumar <dilipbalaut@gmail.com>

To: Alvaro Herrera <alvherre@alvh.no-ip.org>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Andres Freund <andres@anarazel.de>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Petr Jelinek <petr.jelinek@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Tomas Vondra <tomas.vondra@enterprisedb.com>

Date: 2021-06-10T08:42:25Z

Lists: pgsql-hackers

Attachments

v5-0001-Bug-fix-for-speculative-abort_HEAD.patch (text/x-patch) patch v5-0001
v5-0001-Bug-fix-for-speculative-abort-v10.patch (text/x-patch) patch v5-0001
v5-0001-Bug-fix-for-speculative-abort-v12_and_v13.patch (text/x-patch) patch v5-0001
v5-0001-Bug-fix-for-speculative-abort-v96.patch (text/x-patch) patch v5-0001
v5-0001-Bug-fix-for-speculative-abort-v11.patch (text/x-patch) patch v5-0001
v5-0002-Test-logical-decoding-of-speculative-aborts_HEAD.patch (text/x-patch) patch v5-0002
v5-0002-Test-logical-decoding-of-speculative-aborts-v10.patch (text/x-patch) patch v5-0002
v5-0002-Test-logical-decoding-of-speculative-aborts-v11.patch (text/x-patch) patch v5-0002
v5-0002-Test-logical-decoding-of-speculative-aborts-v12_and_v13.patch (text/x-patch) patch v5-0002
v5-0002-Test-logical-decoding-of-speculative-aborts-v96.patch (text/x-patch) patch v5-0002

On Wed, Jun 9, 2021 at 8:59 PM Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> May I suggest to use a different name in the blurt_and_lock_123()
> function, so that it doesn't conflict with the one in
> insert-conflict-specconflict?  Thanks

Renamed to blurt_and_lock(), is that fine?

I haved fixed other comments and also prepared patches for the back branches.

-- 
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com

Commits

Fix ABI break introduced by commit 4daa140a2f.
- e95f617acc48 11.13 landed
- 72b51e214a2c 12.8 landed
- 56e366f6757d 13.4 landed
Fix valgrind issue in pgoutput.c.
- 357cb8f07f95 13.4 landed
Fix decoding of speculative aborts.
- 43acadfcebec 9.6.23 landed
- 35f56c124a7a 10.18 landed
- 1f8a934e0a86 11.13 landed
- 40ad7ebff6ca 12.8 landed
- 602a32a685e4 13.4 landed
- 4daa140a2f50 14.0 landed
pgoutput: Fix memory leak due to RelationSyncEntry.map.
- d2505681211b 13.4 cited
Fix initialization of RelationSyncEntry for streaming transactions.
- 69bd60672af6 14.0 cited
Implement streaming mode in ReorderBuffer.
- 7259736a6e5b 14.0 cited