Horton

Re: Connection slots reserved for replication

Alexander Kukushkin <cyberdemn@gmail.com>

View thread View on postgr.es
From: Alexander Kukushkin <cyberdemn@gmail.com>
To: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Oleksii Kliukin <alexk@hintbits.com>, Stephen Frost <sfrost@snowman.net>, magnus@hagander.net, Masahiko Sawada <sawada.mshk@gmail.com>, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-12-17T13:10:19Z
Lists: pgsql-hackers

Attachments

Hi,

On Thu, 6 Dec 2018 at 00:55, Petr Jelinek <petr.jelinek@2ndquadrant.com> wrote:
> > Does excluding WAL senders from the max_connections limit and including max_wal_senders in MaxBackends also imply that we need to add max_wal_senders to the list at xlog.c: CheckRequiredParameterValues, requiring its value on the replica to be not lower than the one on the primary?
> >
>
> I think it does, we need the proc slots for walsenders on the standby
> same way we do for normal backends.

You are absolutely right. Attaching the new version of the patch.

Regards,
--
Alexander Kukushkin

Commits

  1. Fix description of WAL record XLOG_PARAMETER_CHANGE

  2. Move max_wal_senders out of max_connections for connection slot handling