Horton

Re: pg_rewind WAL segments deletion pitfall

Alexander Kukushkin <cyberdemn@gmail.com>

View thread View on postgr.es
From: Alexander Kukushkin <cyberdemn@gmail.com>
To: Antonin Houska <ah@cybertec.at>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Sutou Kouhei <kou@clear-code.com>, smithpb2250@gmail.com, torikoshia@oss.nttdata.com, horikyota.ntt@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org, bungina@gmail.com, pgsql-hackers@lists.postgresql.org
Date: 2024-11-21T10:42:13Z
Lists: pgsql-bugs, pgsql-hackers

Attachments

On Thu, 21 Nov 2024 at 06:43, Antonin Houska <ah@cybertec.at> wrote:

> When doing some unrelated work I noticed that in the new test
> 010_keep_recycled_wals.pl the server fails to reload the configuration
> file. The line it complains about is
>
> archive_command = '/usr/bin/perl -e 'exit(1)''
>
> The test still succeeds for some reason.
>

Oh, nice catch.

The attached patch should address it.

-- 
Regards,
--
Alexander Kukushkin

Commits

  1. Fix newly introduced 010_keep_recycled_wals.pl

  2. Avoid deleting critical WAL segments during pg_rewind