Re: Support for array_remove and array_replace functions
Alex Hunsaker <badalex@gmail.com>
From: Alex Hunsaker <badalex@gmail.com>
To: Marco Nenciarini <marco.nenciarini@2ndquadrant.it>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2012-07-01T19:20:58Z
Lists: pgsql-hackers
On Sat, Jun 30, 2012 at 3:28 PM, Marco Nenciarini <marco.nenciarini@2ndquadrant.it> wrote: > > On 30/06/2012 04:16, Alex Hunsaker wrote: > > > > Hi, I've been reviewing this patch. > > > > Good documentation, and regression tests. The code looked fine but I > > didn't care for the code duplication between array_replace and > > array_remove so I merged those into a helper function, > > array_replace_internal(). Thoughts? > > It looks reasonable. > > There was a typo in array_replace which was caught by regression tests. > I've fixed the typo and changed a comment in array_replace_internal. > > Patch v3 attached. Looks good to me, marked ready for commiter.