Re: Support for array_remove and array_replace functions

Alex Hunsaker <badalex@gmail.com>

View thread

From: Alex Hunsaker <badalex@gmail.com>

To: Marco Nenciarini <marco.nenciarini@2ndquadrant.it>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2012-06-30T02:16:08Z

Lists: pgsql-hackers

Attachments

array-functions_v2.patch.bz2 (application/x-bzip2)

On Thu, Jun 14, 2012 at 4:41 AM, Marco Nenciarini <
marco.nenciarini@2ndquadrant.it> wrote:

> Hi,
>
>  following Gabriele's email regarding our previous patch on "Foreign
> Key Arrays"[1], I am sending a subset of that patch which includes only
> two array functions which will be needed in that patch: array_remove
> (limited to single-dimensional arrays) and array_replace.
>

>  The patch includes changes to the documentation.
>

Hi, I've been reviewing this patch.

Good documentation, and regression tests. The code looked fine but I didn't
care for the code duplication between array_replace and array_remove so I
merged those into a helper function, array_replace_internal(). Thoughts?

Other than that it all looks good to me.