Re: Review: Non-inheritable check constraints

Alex Hunsaker <badalex@gmail.com>

View thread

From: Alex Hunsaker <badalex@gmail.com>

To: Nikhil Sontakke <nikkhils@gmail.com>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2011-10-09T06:40:36Z

Lists: pgsql-hackers

Attachments

non_inh_check_v3.patch.gz (application/x-gzip) patch v3

On Fri, Oct 7, 2011 at 21:30, Nikhil Sontakke <nikkhils@gmail.com> wrote:
> Hi Alex,
>
> I guess we both are in agreement with each other :)
>
> After sleeping over it, I think that check is indeed dead code with this new
> non-inheritable check constraints functionality in place. So unless you have
> some other comments, we can mark this as 'Ready for Commiter'.
>
> Again, thanks for the thorough review and subsequent changes!

PFA an updated patch with the check removed and a comment or two added.

I've also marked it ready.