Re: [COMMITTERS] pgsql: Fix breakage from earlier plperl fix.

Alex Hunsaker <badalex@gmail.com>

From: Alex Hunsaker <badalex@gmail.com>

To: Andrew Dunstan <andrew@dunslane.net>

Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>

Date: 2012-01-14T00:09:17Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix breakage from earlier plperl fix.
- bd0e74a9ce98 9.2.0 cited

On Fri, Jan 13, 2012 at 16:07, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 01/12/2012 09:28 PM, Alex Hunsaker wrote:
>>
>> Util.c/o not depending on plperl_helpers.h was also throwing me for a loop
>> so I fixed it and SPI.c... Thoughts?
>
>
> Basically looks good, but I'm confused by this:
>
>   do language plperl $$ elog('NOTICE', ${^TAINT}); $$;
>
>
>
> Why is NOTICE quoted here? It's constant that we've been careful to set up.

No reason.

[ Err well It was just part of me flailing around while trying to
figure out why elog was still crashing even thought I had the issue
fixed. The real problem was Util.o was not being recompiled due to
Util.c not depending on plperl_helpers.h) ]