Horton

Re: Add pg_freespacemap extension sql test

Fabrízio de Royes Mello <fabriziomello@gmail.com>

View thread
From: Fabrízio de Royes Mello <fabriziomello@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Dong Wook Lee <sh95119@gmail.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2022-03-23T13:45:19Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Avoid instabilities with the regression tests of pg_freespacemap

  2. Add some basic regression tests for pg_freespacemap

On Wed, Mar 23, 2022 at 3:05 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> After review, I don't like much the idea of allowing concurrent
> autovacuums to run in parallel of the table(s) of this test, so we'd
> better disable it explicitely.

Make sense.

>  "t1" is also a very generic name to use in a regression test.

Agreed!

>  Another thing that itched me is that we
> could also test more with indexes, particularly with btree, BRIN and
> hash (the latter should not have a FSM with 10 pages as per the first
> group batch, and each one has a stable an initial state).

What about GIN/GIST indexes?

> I have extended the set of tests as of the attached, running these
> across everything I could (CI, all my hosts including Windows, macos,
> Linux).  We could do more later, of course, but this looks enough to
> me as a first step.  And I think that this will not upset the
> buildfarm.

Also LGTM.

Regards,

--
Fabrízio de Royes Mello