Re: Failed to request an autovacuum work-item in silence
Fabrízio de Royes Mello <fabriziomello@gmail.com>
From: Fabrízio de Royes Mello <fabriziomello@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-01-23T11:03:55Z
Lists: pgsql-hackers
Em ter, 23 de jan de 2018 às 03:36, Masahiko Sawada <sawada.mshk@gmail.com> escreveu: > Hi all, > > While reading the code, I realized that the requesting an autovacuum > work-item could fail in silence if work-item array is full. So the > users cannot realize that work-item is never performed. > AutoVacuumRequestWork() seems to behave so from the initial > implementation but is there any reason of such behavior? It seems to > me that it can be a problem even now that there is only one kind of > work-item. Attached patch for fixing it. > Seems reasonable but maybe you can use the word "worker" instead of "work item" for report message. -- Fabrízio de Royes Mello Consultoria/Coaching PostgreSQL >> Timbira: http://www.timbira.com.br >> Blog: http://fabriziomello.github.io >> Linkedin: http://br.linkedin.com/in/fabriziomello >> Twitter: http://twitter.com/fabriziomello >> Github: http://github.com/fabriziomello
Commits
-
Log when a BRIN autosummarization request fails
- eadcb7a2377a 10.4 landed
- 484a4a08abe3 11.0 landed