Horton

Re: Sequence Access Method WIP

Fabrízio de Royes Mello <fabriziomello@gmail.com>

View thread View on postgr.es
From: Fabrízio de Royes Mello <fabriziomello@gmail.com>
To: Petr Jelinek <petr@2ndquadrant.com>
Cc: David Steele <david@pgmasters.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Craig Ringer <craig@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2016-04-05T17:54:32Z
Lists: pgsql-hackers

Attachments

On Tue, Apr 5, 2016 at 12:52 PM, Petr Jelinek <petr@2ndquadrant.com> wrote:
>
>> I have just one question about de 0002 patch:
>> - There are some reason to not use TransactionId instead of uint32 in
>> GaplessSequenceState struct?
>>
>
> I missed we have that :)
>

Attached fix it and also I changed to use TransactionIdEquals instead of
compare xids directly.

- if (seqstate->xid != local_xid)
+ if (!TransactionIdEquals(seqstate->xid, local_xid))

IMHO this patch is Ready for Commiter. Changed status in CommitfestApp.

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

Commits

  1. Add missing gss option to msvc config template