Re: Hooks for session start and end, take two

Fabrízio de Royes Mello <fabriziomello@gmail.com>

From: Fabrízio de Royes Mello <fabriziomello@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: legrand legrand <legrand_legrand@hotmail.com>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2019-09-30T17:46:42Z
Lists: pgsql-hackers
On Sun, Sep 29, 2019 at 10:29 PM Michael Paquier <michael@paquier.xyz>
wrote:
>
> This code path can only be taken by normal backends, so that would
> apply, still I don't actually see why we should limit us here on the
> backend side.  If for a reason or another those two code paths begin
> to be taken by a backend with InvalidBackendId, then users of the
> session start/end hook will need to think how to handle it if they
> didn't from the start, which sounds like a good thing to me.
>

Makes sense to me. I become a reviewer and run all tests (make check &&
make check-world) and everything is ok. Changed status to "ready for
commiter".

Regards,

--
   Fabrízio de Royes Mello         Timbira - http://www.timbira.com.br/
   PostgreSQL: Consultoria, Desenvolvimento, Suporte 24x7 e Treinamento

Commits

  1. Add hooks for session start and session end, take two