Horton

Re: Sequence Access Method WIP

Fabrízio de Royes Mello <fabriziomello@gmail.com>

View thread View on postgr.es
From: Fabrízio de Royes Mello <fabriziomello@gmail.com>
To: Petr Jelinek <petr@2ndquadrant.com>
Cc: David Steele <david@pgmasters.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Craig Ringer <craig@2ndquadrant.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2016-04-04T13:53:13Z
Lists: pgsql-hackers

Attachments

On Thu, Mar 31, 2016 at 9:19 AM, Petr Jelinek <petr@2ndquadrant.com> wrote:
>
> Hi,
>
> new version attached that should fix the issue. It was alignment -
honestly don't know what I was thinking using fixed alignment when the AMs
can define their own type.
>

Yeah... now all works fine... I had a minor issue when apply to the current
master but the attached fix it and I also added tab-complete support for
CREATE SEQUENCE...USING and ALTER SEQUENCE...USING.

I ran all the regression tests and all passed.

I have just one question about de 0002 patch:
- There are some reason to not use TransactionId instead of uint32 in
GaplessSequenceState struct?

Regards,

--
Fabrízio de Royes Mello
Consultoria/Coaching PostgreSQL
>> Timbira: http://www.timbira.com.br
>> Blog: http://fabriziomello.github.io
>> Linkedin: http://br.linkedin.com/in/fabriziomello
>> Twitter: http://twitter.com/fabriziomello
>> Github: http://github.com/fabriziomello

Commits

  1. Add missing gss option to msvc config template