Horton

Re: Add minimal C example and SQL registration example for custom table access methods.

Fabrízio de Royes Mello <fabriziomello@gmail.com>

View thread
From: Fabrízio de Royes Mello <fabriziomello@gmail.com>
To: Roberto Mello <roberto.mello@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2024-01-26T20:02:59Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. doc: Add minimal C and SQL example to add a custom table AM handler

On Wed, Nov 15, 2023 at 8:29 PM Roberto Mello <roberto.mello@gmail.com>
wrote:
>
> Suggestion:
>
> In the C example you added you mention in the comment:
>
> +  /* Methods from TableAmRoutine omitted from example, but all
> +     non-optional ones must be provided here. */
>
> Perhaps you could provide a "see <xyz>" to point the reader finding your
example where he could find these non-optional methods he must provide?
>
> Nitpicking a little: your patch appears to change more lines than it
does, because it added line breaks earlier in the lines. I would generally
avoid that unless there's good reason to do so.

Hey folks,

There is a previous patch [1] around the same topic. What about joining
efforts on pointing these documentation changes to the proposed test module?

[1] https://commitfest.postgresql.org/46/4588/

-- 
Fabrízio de Royes Mello