Horton

Re: Excessive number of replication slots for 12->14 logical replication

Ajin Cherian <itsajin@gmail.com>

View thread View on postgr.es
From: Ajin Cherian <itsajin@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, Hubert Lubaczewski <depesz@depesz.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2022-08-11T15:04:30Z
Lists: pgsql-bugs

Attachments

On Thu, Aug 4, 2022 at 5:42 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> Thank you for working on this. I have a comment and a question:
>
>                   * This has to be done after updating the state
> because otherwise if
>                   * there is an error while doing the database
> operations we won't be
> -                 * able to rollback dropped slot.
> +                 * able to rollback dropped slot or origin tracking.
>
> I think we can actually roll back dropping the replication origin. So
> the above comment is true for only replication slots.
>

Fixed this.

regards,
Ajin Cherian
Fujitsu Australia

Commits

  1. Make the tablesync worker's replication origin drop logic robust.

  2. Drop replication origin slots before tablesync worker exits.

  3. Allow multiple xacts during table sync in logical replication.