Horton

Re: Support logical replication of DDLs

Ajin Cherian <itsajin@gmail.com>

View thread
From: Ajin Cherian <itsajin@gmail.com>
To: Zheng Li <zhengli10@gmail.com>
Cc: Runqi Tian <runqidev@gmail.com>, vignesh C <vignesh21@gmail.com>, Peter Smith <smithpb2250@gmail.com>, li jie <ggysxcq@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Japin Li <japinli@hotmail.com>, rajesh singarapu <rajesh.rs0541@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-03-14T04:17:20Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add a run_as_owner option to subscriptions.

  2. Refactor pgoutput_change().

  3. Print the correct aliases for DML target tables in ruleutils.

  4. Fix object identity string for transforms

  5. Add grantable MAINTAIN privilege and pg_maintain role.

  6. Get rid of recursion-marker values in enum AlterTableType

  7. Release cache tuple when no longer needed

  8. Empty search_path in logical replication apply worker and walsender.

  9. Refactor format_type APIs to be more modular

  10. Use wrappers of PG_DETOAST_DATUM_PACKED() more.

Attachments

On Mon, Mar 13, 2023 at 2:24 AM Zheng Li <zhengli10@gmail.com> wrote:
>
> Thanks for working on the test coverage for CREATE and ALTER TABLE.
> I've made fixes for some of the failures in the v79 patch set (0002,
> 0003 and 0004 are updated). The changes includes:
> 1. Fixed a syntax error caused by ON COMMIT clause placement in
> deparse_CreateStmt.
> 2. Fixed deparse_Seq_As and start using it in deparse_CreateSeqStmt,
> this issue is also reported in [1].
> 3. Fixed a bug in append_not_present: the 'present: false' element
> can't be omitted even in non-verbose mode. It will cause syntax error
> on reformed command if 'present: false' element is missing but the fmt
> string indicates the corresponding object must be present.
> 4. Replaced if_not_exists with if_exists in deparse of
> AT_DropConstraint and AT_DropColumn.
> 5. Added missing CASCADE clause for AT_DropConstraint deparse.
> 6. Enabled the fixed test cases.
>

I found out that the option ONLY was not parsed in the "CREATE INDEX" command,
for eg: CREATE UNIQUE INDEX ... ON ONLY table_name ...

I've fixed this in patch 0002.

regards,
Ajin Cherian
Fujitsu Australia