Re: Decoding of two-phase xacts missing from CREATE_REPLICATION_SLOT command

Ajin Cherian <itsajin@gmail.com>

From: Ajin Cherian <itsajin@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: Jeff Davis <pgsql@j-davis.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Amit Kapila <akapila@postgresql.org>, vignesh C <vignesh21@gmail.com>, Peter Smith <smithpb2250@gmail.com>

Date: 2021-06-04T08:59:35Z

Lists: pgsql-hackers

Attachments

v1-0001-Remove-two-phase-option-from-CreateReplicationSlo.patch (application/octet-stream) patch v1-0001
v1-0002-Add-option-to-set-two-phase-in-CREATE_REPLICATION.patch (application/octet-stream) patch v1-0002

On Fri, Jun 4, 2021 at 1:06 PM Amit Kapila <amit.kapila16@gmail.com> wrote:

> I think we can try but not sure if we can get it by then. So, here is
> my suggestion:
> a. remove the change in CreateReplicationSlotCmd
> b. prepare the patches for protocol change and pg_recvlogical. This
> will anyway include the change we removed as part of (a).

Attaching two patches:
1. Removes two-phase from CreateReplicationSlotCmd
2. Adds two-phase option in CREATE_REPLICATION_SLOT command.

I will send a patch to update pg_recvlogical next week.

regards,
Ajin Cherian
Fujitsu Australia

Commits

Remove two_phase variable from CreateReplicationSlotCmd struct.
- be57f21650d3 14.0 landed
Add option to enable two_phase commits via pg_create_logical_replication_slot.
- 19890a064ebf 14.0 cited