Re: Failure of subscription tests with topminnow

Ajin Cherian <itsajin@gmail.com>

From: Ajin Cherian <itsajin@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: Masahiko Sawada <sawada.mshk@gmail.com>, Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@lists.postgresql.org>

Date: 2021-08-27T11:03:17Z

Lists: pgsql-hackers

Attachments

HEAD-v2-0001-fix-for-tap-test-failure-seen-in-001_rep_changes.patch (application/octet-stream) patch v2-0001
REL-13-STABLE-v1-0001-fix-for-tap-test-failure-seen-in-001_rep_changes.patch (application/octet-stream) patch v1-0001
REL-12-STABLE-v1-0001-fix-for-tap-test-failure-seen-in-001_rep_changes.patch (application/octet-stream) patch v1-0001
REL-10-STABLE-v1-0001-fix-for-tap-test-failure-seen-in-001_rep_changes.patch (application/octet-stream) patch v1-0001
REL-11-STABLE-v1-0001-fix-for-tap-test-failure-seen-in-001_rep_changes.patch (application/octet-stream) patch v1-0001
REL-14-STABLE-v1-0001-fix-for-tap-test-failure-seen-in-001_rep_changes.patch (application/octet-stream) patch v1-0001

On Fri, Aug 27, 2021 at 3:29 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
>
> I think the fix is correct but similar changes are required in
> 022_twophase_cascade.pl as well (search for $oldpid in tests). I am
> not completely sure but I think it is better to make this test change
> in back branches as well to make it stable and reduce such random
> build farm failures.

I have made the changes in 022_twophase_cascade.pl for HEAD as well as
patches for older branches.

regards,
Ajin Cherian
Fujitsu Australia

Commits

Fix the random test failure in 001_rep_changes.
- 8d0138ef51b5 15.0 landed
- b7ad093d50e1 14.0 landed
- 387093e43225 10.19 landed
- 56683e1684ef 11.14 landed
- df6ab94aca90 12.9 landed
- b51985d8a0e1 13.5 landed