Re: Logical replication timeout problem

Ajin Cherian <itsajin@gmail.com>

From: Ajin Cherian <itsajin@gmail.com>

To: "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>

Cc: "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, Peter Smith <smithpb2250@gmail.com>, Fabrice Chapuis <fabrice636861@gmail.com>, Simon Riggs <simon.riggs@enterprisedb.com>, Petr Jelinek <petr.jelinek@enterprisedb.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-03-08T03:53:43Z

Lists: pgsql-hackers

On Tue, Mar 8, 2022 at 12:25 PM wangw.fnst@fujitsu.com
<wangw.fnst@fujitsu.com> wrote:
> Attach the new patch.
> 1. Fix wrong variable setting and skip unnecessary time records.[suggestion by Kuroda-San and me.]
> 2. Introduce version information.[suggestion by Peter, Kuroda-San]
>
> Regards,
> Wang wei

Some comments.

1. The comment  on top of SendKeepaliveIfNecessary

 Try to send a keepalive message if too many changes was skipped.

change to

Try to send a keepalive message if too many changes wer skipped.

2. In pgoutput_change:

+ /* Reset the counter for skipped changes. */
+ SendKeepaliveIfNecessary(ctx, false);
+

This reset is called too early, this function might go on to skip
changes because of the row filter, so this
reset fits better once we know for sure that a change is sent out. You
will also need to send keep alive
when the change is skipped due to the row filter.

regards,
Ajin Cherian
Fujitsu Australia

Commits

Fix the logical replication timeout during large DDLs.
- 8c58624df462 16.0 landed
Fix the logical replication timeout during large transactions.
- f95d53eded55 15.0 landed
- d6da71fa8f28 14.4 landed
- 55558df23741 13.8 landed
- f832b5007c1c 12.12 landed
- 87c1dd246af8 11.17 landed
- a4015ec0375d 10.22 landed
Rethink the delay-checkpoint-end mechanism in the back-branches.
- 10520f434687 14.3 cited
Revert "Logical decoding of sequences"
- 2c7ea57e56ca 15.0 cited
Skip empty transactions for logical replication.
- d5a9d86d8ffc 15.0 cited
Allow specifying column lists for logical replication
- 923def9a533a 15.0 cited
Add decoding of sequences to built-in replication
- 75b1521dae1f 15.0 cited
Fix ABI break introduced by commit 4daa140a2f.
- 56e366f6757d 13.4 cited
Lag tracking for logical replication
- 024711bb5446 10.0 cited