Re: Support reset of Shared objects statistics in "pg_stat_reset" function

Sadhuprasad Patro <b.sadhu@gmail.com>

From: Sadhuprasad Patro <b.sadhu@gmail.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Himanshu Upadhyaya <upadhyaya.himanshu@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-08-22T17:23:47Z
Lists: pgsql-hackers

Attachments

> On 2021/08/20 11:07, Mahendra Singh Thalor wrote:
> > 1)
> >           Resets statistics for a single table or index in the current database
> > -        to zero.
> > +        to zero. The input can be a shared table also
> >
> > I think, above comment should be modified. Maybe, we can modify it as "If input is a shared oid(table or index or toast), then resets statistics for a single shared entry to zero.
>
> I'm not sure if ordinary users can understand what "shared oid" means. Instead,
> what about "Resets statistics for a single relation in the current database or
> shared across all databases in the cluster to zero."?
>

Thank you for the review here. As per the comments, attached the
latest patch here...


Thanks & Regards
SadhuPrasad
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Enhance pg_stat_reset_single_table_counters function.