Thread

  1. Re: Potential problem in commit f777d773878 and 4f7f7b03758

    Srinath Reddy Sadipiralla <srinath2133@gmail.com> — 2025-08-24T23:46:15Z

    On Sun, Aug 24, 2025 at 5:58 PM Srinath Reddy Sadipiralla <
    srinath2133@gmail.com> wrote:
    
    > Hi,
    > Thanks Dilip and Matheus for working on this , i reviewed the latest patch
    > given my Matheus and it LGTM but i have doubt that in f777d773878 commit
    > the $libdir was moved out from expand_dynamic_library_name
    > into load_external_function because if someone specifies LOAD '$libdir/foo'
    > explicitly they want to get the foo.so from $libdir not from other paths
    > given in dynamic_library_path ,i think same should go for the case when we
    > do "create extension" will try to execute the sql script which will replace
    > the MODULE_PATHNAME with module_pathname from .control file lets say which
    > is $libdir/foo ,now during the sql functions execution this calls the
    > load_external_function where we strip $libdir and we are going to load the
    > foo.so from other paths specified in dynamic_library_path, isn't that a
    > problem , i think this case is also same as with the LOAD.
    >
    
    sorry i missed to mention "stripping of $libdir"  here " but i have a doubt
    that in f777d773878 commit the stripping of $libdir was moved out
    from expand_dynamic_library_name into load_external_function "
    
    -- 
    Thanks,
    Srinath Reddy Sadipiralla
    EDB: https://www.enterprisedb.com/