Re: getting "shell command argument contains a newline or carriage return:" error with pg_dumpall when db name have new line in double quote

Srinath Reddy Sadipiralla <srinath2133@gmail.com>

From: Srinath Reddy <srinath2133@gmail.com>

To: Mahendra Singh Thalor <mahi6run@gmail.com>

Cc: alvherre@alvh.no-ip.org, Andrew Dunstan <andrew@dunslane.net>, nathandbossart@gmail.com, pgsql-hackers@lists.postgresql.org

Date: 2025-03-29T18:33:10Z

Lists: pgsql-hackers

Attachments

v05_002-Log-about-all-the-invalid-database-role-user-names-t.patch (application/octet-stream)

./psql postgres

Hi,

On Fri, Mar 28, 2025 at 5:08 PM Mahendra Singh Thalor <mahi6run@gmail.com>
wrote:

>
> v04_001* has the changes for CREATE DATABASE/ROLE/USER and
> v04_002* has the changes into pg_upgrade to give ALERTS for invalid names.
>

i have reviewed these patches,in v04_002* i think it would be better if log
all the names like database ,roles/users names then throw error instead of
just logging database names into db_role_invalid_names and throwing
error,which helps the user to see at once all the invalid names and resolve
then again try pg_upgrade,so here i am attaching delta patch for the same
,except this the patches LGTM.

May the force be with you,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

postgres=# \q