Horton

Re: Making pg_rewind faster

Srinath Reddy Sadipiralla <srinath2133@gmail.com>

View thread
From: Srinath Reddy Sadipiralla <srinath2133@gmail.com>
To: John H <johnhyvr@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, wenhui qiu <qiuwenhuifx@gmail.com>, Japin Li <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>, Andres Freund <andres@anarazel.de>, Alexander Korotkov <aekorotkov@gmail.com>, Justin Kwan <justinpkwan@outlook.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>, vignesh ravichandran <admin@viggy28.dev>, "hlinnaka@iki.fi" <hlinnaka@iki.fi>
Date: 2025-10-21T04:36:26Z
Lists: pgsql-hackers 
Hi John,

On Tue, Oct 21, 2025 at 3:34 AM John H <johnhyvr@gmail.com> wrote:

>
> > 3) maybe we can improve the error messages for the
> > last 2 checks in tap test, that because of this
> > reason hence proven that the copy from source to
> > target has been done.
>
> What are you thinking of? Something like the below?
>
> +       "Expected WAL segment $corrupt_wal_seg to have been modified
> due to rewind");
> +       "Expected WAL segment $corrupt_wal_seg to have been synced
> from source to target after rewind");
>

maybe something like this
+ "Expected WAL segment $corrupt_wal_seg to have later mtime
on target than source after rewind as it was copied");
+ "Expected WAL segment $corrupt_wal_seg file sizes to be same
between target and source after rewind as it was copied");

-- 
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/