Re: Incorrect include file order in guc-file.l
John Naylor <john.naylor@enterprisedb.com>
From: John Naylor <john.naylor@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Julien Rouhaud <rjuju123@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-03T12:19:07Z
Lists: pgsql-hackers
On Thu, Nov 3, 2022 at 6:40 PM Michael Paquier <michael@paquier.xyz> wrote: > > On Thu, Nov 03, 2022 at 12:40:19PM +0700, John Naylor wrote: > > On Wed, Nov 2, 2022 at 1:01 PM Julien Rouhaud <rjuju123@gmail.com> wrote: > >> Agreed, it's apparently an oversight in dac048f71eb. +1 for the patch. > > > > I've pushed this, thanks! > > Thanks for the commit. I've wanted to get it done yesterday but life > took over faster than that. Before committing the change, there is > something I have noticed though: this header does not seem to be > necessary at all and it looks that there is nothing in guc-file.l that > needs it. Why did you add it in dac048f to begin with? Because it wouldn't compile otherwise, obviously. :-) I must have been working on it before bfb9dfd93720 -- John Naylor EDB: http://www.enterprisedb.com
Commits
-
Remove unneeded includes of <sys/stat.h>
- 2a71de8915b4 16.0 landed
-
Remove outdated include
- 233cf6e8adfc 16.0 landed
-
Straighten include order in guc-file.l
- 062eef3a9bbd 16.0 landed