Re: duplicate function oid symbols

John Naylor <john.naylor@enterprisedb.com>

View thread View on postgr.es

From: John Naylor <john.naylor@enterprisedb.com>

To: Tom Lane <tgl@sss.pgh.pa.us>

Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2020-10-28T19:58:33Z

Lists: pgsql-hackers

Attachments

forbid-custom-pg-type-symbols.patch (application/octet-stream) patch

On Wed, Oct 28, 2020 at 3:24 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

>
> Nah.  What I'm imagining is just that pg_type.h contains
>
> #ifdef EXPOSE_TO_CLIENT_CODE
>
> /*
>  * Backwards compatibility for ancient random spellings of OID macros.
>  * Don't use these macros in new code.
>  */
> #define CASHOID  MONEYOID
> #define LSNOID   PG_LSNOID
>
> #endif
>

Here is a quick patch implementing this much.

-- 
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

Don't use custom OID symbols in pg_type.dat, either.
- f90149e6285a 14.0 landed
Don't use custom OID symbols in pg_proc.dat.
- 36b93121436c 14.0 landed