Re: Todo: Teach planner to evaluate multiple windows in the optimal order
John Naylor <john.naylor@enterprisedb.com>
From: John Naylor <john.naylor@enterprisedb.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: pghackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-06-30T06:45:32Z
Lists: pgsql-hackers
Attachments
- v3-0001-Split-out-tiebreaker-comparisons-from-comparetup_.patch (text/x-patch) patch v3-0001
On Wed, Feb 15, 2023 at 11:23 AM John Naylor <john.naylor@enterprisedb.com> wrote: > > > On Tue, Feb 14, 2023 at 5:46 PM David Rowley <dgrowleyml@gmail.com> wrote: > > > > I didn't do a detailed review of the sort patch, but I did wonder > > about the use of the name "fallback" in the new functions. The > > comment in the following snippet from qsort_tuple_unsigned_compare() > > makes me think "tiebreak" is a better name. > > I agree "tiebreak" is better. Here is v3 with that change. I still need to make sure the tests cover all cases, so I'll do that as time permits. Also creating CF entry. -- John Naylor EDB: http://www.enterprisedb.com
Commits
-
Split out tiebreaker comparisons from comparetup_* functions
- c9bfa40914be 17.0 landed
-
Add additional regression tests for select_active_windows
- a14a5832923e 16.0 landed