Horton

Re: Typo in pg_db_role_setting.h

John Naylor <john.naylor@enterprisedb.com>

View thread View on postgr.es
From: John Naylor <john.naylor@enterprisedb.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: Japin Li <japinli@hotmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-02T04:13:25Z
Lists: pgsql-hackers 
On Tue, Aug 2, 2022 at 10:06 AM Richard Guo <guofenglinux@gmail.com> wrote:
>
> I'm not sure that we should remove such comments. And a rough search
> shows that there are much more places with this kind of comments, such
> as below:
>
> nbtxlog transam readfuncs walreceiver buffile bufmgr fd latch pmsignal
> procsignal sinvaladt logtape rangetypes

I was talking only about catalog/pg_*.c functions, as in Japin Li's latest
patch. You didn't mention whether your examples fall in the category Tom
mentioned upthread, so I'm not sure what your angle is.

--
John Naylor
EDB: http://www.enterprisedb.com

Commits

  1. Fix comment in pg_db_role_setting.h