Horton

Thread

Commits

  1. Reduce the range of OIDs reserved for genbki.pl.

  2. BRIN minmax-multi indexes

  1. Reducing the range of OIDs consumed by genbki.pl

    Tom Lane <tgl@sss.pgh.pa.us> — 2021-05-26T21:43:02Z

    The attached patch stems from the conversation at [1];
I'm starting a new thread to avoid confusing the cfbot.

Briefly, the idea is to allow reverting the change made in
commit ab596105b to increase FirstBootstrapObjectId from
12000 to 13000, by teaching genbki.pl to assign OIDs
independently in each catalog rather than from a single
OID counter.  Thus, the OIDs in this range will not be
globally unique anymore, but only unique per-catalog.

The aforesaid commit had to increase FirstBootstrapObjectId
because as of HEAD, genbki.pl needs to consume OIDs up through
12035, overrunning the old limit of 12000.  But moving up that
limit seems a bit risky, cf [2].  It'd be better if we could
avoid doing that.  Since the OIDs in question are spread across
several catalogs, allocating them per-catalog seems to fix the
problem quite effectively.  With the attached patch, the ending
OID counters are

GenbkiNextOid(pg_amop) = 10945
GenbkiNextOid(pg_amproc) = 10697
GenbkiNextOid(pg_cast) = 10230
GenbkiNextOid(pg_opclass) = 10164

so we have quite a lot of daylight before we'll ever approach
12000 again.

Per-catalog OID uniqueness shouldn't be a problem here, because
any code that's assuming global uniqueness is broken anyway;
no such guarantee exists after the OID counter has wrapped
around.

So I propose shoehorning this into v14, to avoid shipping a
release where FirstBootstrapObjectId has been bumped up.

			regards, tom lane

[1] https://www.postgresql.org/message-id/flat/3737988.1618451008%40sss.pgh.pa.us

[2] https://www.postgresql.org/message-id/flat/CAGPqQf3JYTrTB1E1fu_zOGj%2BrG_kwTfa3UcUYPfNZL9o1bcYNw%40mail.gmail.com

  2. Re: Reducing the range of OIDs consumed by genbki.pl

    Robert Haas <robertmhaas@gmail.com> — 2021-05-27T14:36:00Z

    On Wed, May 26, 2021 at 5:43 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> So I propose shoehorning this into v14, to avoid shipping a
> release where FirstBootstrapObjectId has been bumped up.

Just to repeat on this thread what I said on the other one, I am +1 on
this as a concept. I have not reviewed the patch.

Thanks,

-- 
Robert Haas
EDB: http://www.enterprisedb.com

  3. Re: Reducing the range of OIDs consumed by genbki.pl

    John Naylor <john.naylor@enterprisedb.com> — 2021-05-27T17:09:59Z

    On Wed, May 26, 2021 at 5:43 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> The attached patch stems from the conversation at [1];
> I'm starting a new thread to avoid confusing the cfbot.

The patch looks good to me.

--
John Naylor
EDB: http://www.enterprisedb.com

  4. Re: Reducing the range of OIDs consumed by genbki.pl

    Tom Lane <tgl@sss.pgh.pa.us> — 2021-05-27T17:34:04Z

    John Naylor <john.naylor@enterprisedb.com> writes:
> The patch looks good to me.

Thanks for reviewing!

			regards, tom lane