Re: document pg_settings view doesn't display custom options

John Naylor <john.naylor@enterprisedb.com>

From: John Naylor <john.naylor@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2020-10-30T17:06:56Z
Lists: pgsql-hackers

Attachments

On Fri, Oct 30, 2020 at 12:48 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

> John Naylor <john.naylor@enterprisedb.com> writes:
> > Okay, along those lines here's a patch using "this view" in a new
> paragraph
> > for simplicity.
>
> Basically OK with me, but ...
>
> <quibble>
> It seems fairly weird to use a nonspecific reference first and then a
> specific one.  That is, I'd expect to read "The pg_settings view ..."
> and then "This view ...", not the other way around.  So we could
> put this para second, or put it first but make this para say
> "The pg_settings view ..." while the existing text gets reduced to
> "This view ...".
>
> Or just make them both say "This view ..." so we don't have to have
> this discussion again the next time somebody wants to add a para here.
> </quibble>
>

Okay, how's this?

-- 
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Commits

  1. doc: Add note about pg_settings and customized options into catalogs.sgml.