Re: Typo in pg_db_role_setting.h

John Naylor <john.naylor@enterprisedb.com>

From: John Naylor <john.naylor@enterprisedb.com>
To: Japin Li <japinli@hotmail.com>
Cc: "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Date: 2022-08-01T12:46:30Z
Lists: pgsql-hackers
On Mon, Aug 1, 2022 at 4:18 PM Japin Li <japinli@hotmail.com> wrote:
>
>
> Hi, hackers
>
> I think there is a typo in pg_db_role_setting.h, should we fix it?
>
> diff --git a/src/include/catalog/pg_db_role_setting.h
b/src/include/catalog/pg_db_role_setting.h
> index 45d478e9e7..f92e867df4 100644
>  /*
> - * prototypes for functions in pg_db_role_setting.h
> + * prototypes for functions in pg_db_role_setting.c
>   */

You are correct, but I wonder if it'd be better to just drop the comment
entirely. I checked a couple other random headers with function
declarations and they didn't have such a comment, and it's kind of obvious
what they're for.

--
John Naylor
EDB: http://www.enterprisedb.com

Commits

  1. Fix comment in pg_db_role_setting.h