Re: pg15b1: FailedAssertion("val > base", File: "...src/include/utils/relptr.h", Line: 67, PID: 30485)
John Naylor <john.naylor@enterprisedb.com>
From: John Naylor <john.naylor@enterprisedb.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Justin Pryzby <pryzby@telsasoft.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
Thomas Munro <thomas.munro@gmail.com>
Date: 2022-06-22T02:49:50Z
Lists: pgsql-hackers
On Wed, Jun 1, 2022 at 2:57 AM Robert Haas <robertmhaas@gmail.com> wrote: > We do use fpm_segment_base(), but that accidentally fails > to break, because instead of using relptr_access() it drills right > through the abstraction and doesn't have any kind of special case for > 0. So we can fix this by: > > 1. Using a relative pointer value other than 0 to represent a null > pointer. Andres suggested (Size) -1. > 2. Not storing the free page manager for the DSM in the main shared > memory segment at byte offset 0. Hi all, For this open item, the above two ideas were discussed as a short-term fix, and my reading of the thread is that the other proposals are too invasive at this point in the cycle. Both of them have a draft patch in the thread. #2, i.e. wasting MAXALIGN of space, seems the simplest and most localized. Any thoughts on pulling the trigger on either of these two approaches? -- John Naylor EDB: http://www.enterprisedb.com
Commits
-
Fix relptr's encoding of the base address.
- 99504ff8265e 14.5 landed
- 7201cd18627a 15.0 landed
-
Suppress compiler warning in relptr_store().
- e07d4ddc55fd 15.0 cited