Re: Some tests for TOAST, STORAGE MAIN/EXTENDED
Nikhil Kumar Veldanda <veldanda.nikhilkumar17@gmail.com>
From: Nikhil Kumar Veldanda <veldanda.nikhilkumar17@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-23T08:25:33Z
Lists: pgsql-hackers
Hi Michael, On Thu, Jan 22, 2026 at 11:04 PM Michael Paquier <michael@paquier.xyz> wrote: > Thoughts or comments? Two nits on the new toasttest block: The `SELECT count(*) FROM :reltoastname` assertion is a bit brittle for `STORAGE EXTENDED`: depending on the toast compression method / effectiveness, the value may end up as >1 chunk, which would flip the expected count(*) = 1. Prefer SELECT count(DISTINCT chunk_id) FROM :reltoastname (or WHERE chunk_seq = 0) and adjust expected. pg_column_compression() expects pglz, but default_toast_compression isn’t pinned here. Suggest SET default_toast_compression = 'pglz'; near this block; otherwise this can fail on builds with a different default. -- Nikhil Veldanda
Commits
-
Add more tests with clause STORAGE on table and TOAST interactions
- 168765e5d42b 19 (unreleased) landed