Horton

Re: Latest patches break one of our unit-test, related to RLS

Dominique Devienne <ddevienne@gmail.com>

View thread View on postgr.es
From: Dominique Devienne <ddevienne@gmail.com>
To: Adrian Klaver <adrian.klaver@aklaver.com>
Cc: pgsql-general@postgresql.org
Date: 2025-09-04T15:45:41Z
Lists: pgsql-general 
On Thu, Sep 4, 2025 at 5:31 PM Dominique Devienne <ddevienne@gmail.com> wrote:
> On Thu, Sep 4, 2025 at 5:12 PM Adrian Klaver <adrian.klaver@aklaver.com> wrote:
> > On 9/4/25 08:03, Dominique Devienne wrote:
> > > But now, we've ascertain that a particular test is:
> > > OK with 16.9 and 17.5 (we cannot test on beta2 anymore)
> > > KO with 16.10 and 17.6 (and beta3 too, released at the same time)
>
> > How did you move from one version to the other?
>
> We first upgraded in place. Broke that test.

We're still naive I guess. And didn't expect a minor upgrade to break us...

Given this mishap, we'll do the reverse from now on.
Install fresh clusters for the new versions (minor or not), and see
what happens.
So we don't "advance" our main/primary (testing) clusters until
"issues are resolved".

Commits

  1. Amend recent fix for SIMILAR TO regex conversion.

  2. Fix conversion of SIMILAR TO regexes for character classes