Horton

Re: pg_dumpall with flag --no-role-passwords omits roles comments as well

Dominique Devienne <ddevienne@gmail.com>

View thread View on postgr.es
From: Dominique Devienne <ddevienne@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Bartosz Chroł <bartosz.chrol@handen.pl>, "pgsql-general@postgresql.org" <pgsql-general@postgresql.org>
Date: 2024-03-21T10:52:12Z
Lists: pgsql-general 
On Thu, Mar 21, 2024 at 11:46 AM Daniel Gustafsson <daniel@yesql.se> wrote:

> > However I noticed that comments on roles are also omitted from the dump,
> as if --no--comments flag was set - but it wasn't.
>
> Comments on roles are stored against the pg_authid catalog relation


Hi. What do you mean? ROLEs are not stored in that relation.
And AFAIK, only accessible via functions using the OID or NAME.

So the relation used, pg_authid or pg_roles, shouldn't matter, no?

Here's my own query for example:
```
select rolname, rolsuper, rolinherit, rolcreaterole,
       rolcreatedb, rolcanlogin, rolreplication, rolbypassrls,
       oid, shobj_description(oid, 'pg_authid')
  from pg_roles
...
```
--DD

Commits

  1. Fix dumping role comments when using --no-role-passwords