Horton

Re: Latest patches break one of our unit-test, related to RLS

Dominique Devienne <ddevienne@gmail.com>

View thread View on postgr.es
From: Dominique Devienne <ddevienne@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-general@postgresql.org
Date: 2025-09-04T15:28:41Z
Lists: pgsql-general 
On Thu, Sep 4, 2025 at 5:18 PM Laurenz Albe <laurenz.albe@cybertec.at> wrote:
> On Thu, 2025-09-04 at 17:03 +0200, Dominique Devienne wrote:
> > OK with 16.9 and 17.5 (we cannot test on beta2 anymore)
> > KO with 16.10 and 17.6 (and beta3 too, released at the same time)
> >
> > Which for a minor patch is a surprise to us, not in a good way.
> >
> > So... Did anything change around RLS in this patch series?
> > Anything changed around ROLE INHERIT rules?
> >
> > The symptom is that a LOGIN user lacks ROLEs is used to have.
> > So perhaps some GRANTs are now silently doing nothing,
> > for some unknown reasons.
> >
> > What in these patches could be affecting those areas?
>
> Without a reproducer, that is a wild goose chase.

Oh, it's easy to reproduce here...
But distilling it down is no small feat.
But this is a patch. Patches are not supposed to break things.

Commits

  1. Amend recent fix for SIMILAR TO regex conversion.

  2. Fix conversion of SIMILAR TO regexes for character classes