Re: new createuser option for replication role
Cédric Villemain <cedric.villemain.debian@gmail.com>
From: Cédric Villemain <cedric.villemain.debian@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2011-09-23T13:47:15Z
Lists: pgsql-hackers
2011/9/23 Robert Haas <robertmhaas@gmail.com>: > On Thu, Sep 22, 2011 at 12:45 PM, Fujii Masao <masao.fujii@gmail.com> wrote: >> Agreed. Attached is the updated version of the patch. It adds two options >> --replication and --no-replication. If neither specified, neither REPLICATION >> nor NOREPLICATION is specified in CREATE ROLE, i.e., in this case, >> replication privilege is granted to only superuser. > > Committed. Do we need to make any changes in interactive mode, when > we prompt? In theory this could be either wanted or not wanted for > either superusers or non-superusers, but I'm not really sure it's > worth it, and I certainly don't want the command to go into > interactive mode just because neither --replication nor > --no-replication was specified. > > Thoughts? I believe the intereactive mode is useless. There is still an issue with the patch for the documentation: a superuser, even with NOREPLICATION is allowed to perform pg_start_backup() and pg_stop_backup(). > > -- > Robert Haas > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Cédric Villemain +33 (0)6 20 30 22 52 http://2ndQuadrant.fr/ PostgreSQL: Support 24x7 - Développement, Expertise et Formation