Horton

Thread

Commits

  1. Fix some grammar errors in bloom.sgml

  2. contrib/bloom documentation improvement

  1. bloom documentation patch

    Oleg Bartunov <obartunov@postgrespro.ru> — 2018-10-14T21:14:32Z

    Hi,

Please, consider attached patch, which improves contrib/bloom documentation.

Best regards,
Oleg
-- 
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

  2. Re: bloom documentation patch

    Thomas Munro <thomas.munro@enterprisedb.com> — 2018-10-14T21:47:27Z

    On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <obartunov@postgrespro.ru> wrote:
> Please, consider attached patch, which improves contrib/bloom documentation.

Hello Oleg, I have no comment on the technical details but here is
some proof-reading of the English:

+      Length of each signature (index entry) in bits, it is rounded
up to the nearest
+      multiple of 16. The default is <literal>80</literal> bits and maximum is

s/, it is/.  It is/
s/and maximum/and the maximum/

+       Bloom AM doesn't supports <literal>unique</literal> indexes.

s/supports/support/

+       Bloom AM doesn't supports <literal>NULL</literal> values.

s/supports/support/

-- 
Thomas Munro
http://www.enterprisedb.com

  3. Re: bloom documentation patch

    Oleg Bartunov <obartunov@postgrespro.ru> — 2018-10-17T20:45:30Z

    On Mon, Oct 15, 2018 at 12:48 AM Thomas Munro
<thomas.munro@enterprisedb.com> wrote:
>
> On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <obartunov@postgrespro.ru> wrote:
> > Please, consider attached patch, which improves contrib/bloom documentation.
>
> Hello Oleg, I have no comment on the technical details but here is
> some proof-reading of the English:
>
> +      Length of each signature (index entry) in bits, it is rounded
> up to the nearest
> +      multiple of 16. The default is <literal>80</literal> bits and maximum is
>
> s/, it is/.  It is/
> s/and maximum/and the maximum/
>
> +       Bloom AM doesn't supports <literal>unique</literal> indexes.
>
> s/supports/support/
>
> +       Bloom AM doesn't supports <literal>NULL</literal> values.
>
> s/supports/support/
>

Thanks, Thomas, new patch attached.

> --
> Thomas Munro
> http://www.enterprisedb.com
>


-- 
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

  4. Re: bloom documentation patch

    Alexander Korotkov <a.korotkov@postgrespro.ru> — 2018-10-21T21:33:42Z

    On Wed, Oct 17, 2018 at 11:45 PM Oleg Bartunov <obartunov@postgrespro.ru> wrote:
> On Mon, Oct 15, 2018 at 12:48 AM Thomas Munro
> <thomas.munro@enterprisedb.com> wrote:
> >
> > On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <obartunov@postgrespro.ru> wrote:
> > > Please, consider attached patch, which improves contrib/bloom documentation.
> >
> > Hello Oleg, I have no comment on the technical details but here is
> > some proof-reading of the English:
> >
> > +      Length of each signature (index entry) in bits, it is rounded
> > up to the nearest
> > +      multiple of 16. The default is <literal>80</literal> bits and maximum is
> >
> > s/, it is/.  It is/
> > s/and maximum/and the maximum/

Thank you for these corrections.  They are pushed.

> > +       Bloom AM doesn't supports <literal>unique</literal> indexes.
> >
> > s/supports/support/
> >
> > +       Bloom AM doesn't supports <literal>NULL</literal> values.
> >
> > s/supports/support/

These two were already fixed in the version I've pushed before.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company