Horton

Thread

Commits

  1. doc: Fix type of cursor_position in jsonlog table

  1. jsonlog cursor_position type is wrong.

    nuko yokohama <nuko.yokohama@gmail.com> — 2022-10-23T22:58:58Z

    Hi.

PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
"Type" in cursor_position should be "number", not "Sting".
https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-KEYS-VALUES

  2. Re: jsonlog cursor_position type is wrong.

    Tatsuo Ishii <ishii@sraoss.co.jp> — 2022-10-24T03:24:16Z

    > Hi.
> 
> PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
> "Type" in cursor_position should be "number", not "Sting".
> https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-KEYS-VALUES

Yeah, that's a typo. Patch attached.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

  3. Re: jsonlog cursor_position type is wrong.

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-10-24T04:53:26Z

    Tatsuo Ishii <ishii@sraoss.co.jp> writes:
>> PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
>> "Type" in cursor_position should be "number", not "Sting".
>> https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-KEYS-VALUES

> Yeah, that's a typo. Patch attached.

Shouldn't it be "integer"?

			regards, tom lane

  4. Re: jsonlog cursor_position type is wrong.

    Michael Paquier <michael@paquier.xyz> — 2022-10-24T05:04:48Z

    On Mon, Oct 24, 2022 at 12:53:26AM -0400, Tom Lane wrote:
> Tatsuo Ishii <ishii@sraoss.co.jp> writes:
>> Yeah, that's a typo. Patch attached.

Thanks, that's wrong :/

> Shouldn't it be "integer"?

When it comes down to the data types of a JSON object, these are
referred as "number", as these can be either integers or floating
points.  See:
https://www.w3schools.com/js/js_json_datatypes.asp
--
Michael

  5. Re: jsonlog cursor_position type is wrong.

    Michael Paquier <michael@paquier.xyz> — 2022-10-25T00:31:03Z

    On Mon, Oct 24, 2022 at 02:04:48PM +0900, Michael Paquier wrote:
> Thanks, that's wrong :/

Anyway, this one is on me, so applied.  Thanks for the patch and the
report!
--
Michael

  6. Re: jsonlog cursor_position type is wrong.

    Tatsuo Ishii <ishii@sraoss.co.jp> — 2022-10-25T00:48:38Z

    > On Mon, Oct 24, 2022 at 02:04:48PM +0900, Michael Paquier wrote:
>> Thanks, that's wrong :/
> 
> Anyway, this one is on me, so applied.  Thanks for the patch and the
> report!

Thank you!
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp