BufmgrCommit no-op since 2008, remaining uses?
Matthias van de Meent <boekewurm+postgres@gmail.com>
From: Matthias van de Meent <boekewurm+postgres@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
Heikki Linnakangas <hlinnaka@iki.fi>
Date: 2023-03-29T11:51:36Z
Lists: pgsql-hackers
Hi, Whilst reading up on the transaction commit code, I noticed the following lines: /* Tell bufmgr and smgr to prepare for commit */ BufmgrCommit(); BufmgrCommit does exactly nothing; it is an empty function and has been since commit 33960006 in late 2008 when it stopped calling smgrcommit(). All two usages of the function (in our code base) seem to be in xact.c. Are we maintaining it for potential future use, or can the function be removed? Kind regards, Matthias van de Meent
Commits
-
Remove empty function BufmgrCommit().
- 58c9600a9f58 16.0 landed
-
Rethink the way FSM truncation works. Instead of WAL-logging FSM
- 3396000684b4 8.4.0 cited