Re: Improvements and additions to COPY progress reporting

Matthias van de Meent <boekewurm+postgres@gmail.com>

From: Matthias van de Meent <boekewurm+postgres@gmail.com>

To:

Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, Josef Šimánek <josef.simanek@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Tomas Vondra <tomas.vondra@enterprisedb.com>

Date: 2021-02-12T12:10:46Z

Lists: pgsql-hackers

Attachments

v5-0006-Add-copy-progress-reporting-regression-tests.patch (text/x-patch) patch v5-0006
v5-0005-Add-copy-progress-reporting-regression-tests.patch (text/x-patch) patch v5-0005
v5-0002-Add-backlinks-to-progress-reporting-documentation.patch (text/x-patch) patch v5-0002
v5-0004-Add-a-io_target-column-to-the-copy-progress-view.patch (text/x-patch) patch v5-0004
v5-0003-Add-a-command-column-to-the-copy-progress-view.patch (text/x-patch) patch v5-0003
v5-0001-Rename-lines-to-tuples-in-COPY-progress-reporting.patch (text/x-patch) patch v5-0001

On Fri, 12 Feb 2021 at 12:23, Matthias van de Meent
<boekewurm+postgres@gmail.com> wrote:
>
> On Thu, 11 Feb 2021 at 15:44, Bharath Rupireddy
> <bharath.rupireddyforpostgres@gmail.com> wrote:
> >
> >
> > On Thu, Feb 11, 2021, 8:08 PM Josef Šimánek <josef.simanek@gmail.com> wrote:
> >> I have split it since it should be the start of progress reporting
> >> testing at all. If you better consider this as part of COPY testing,
> >> feel free to move it to already existing copy testing related files.
> >> There's no real reason to keep it separated if not needed.
> >
> >
> > +1 to move those test cases to existing copy test files.
>
> Thanks for your reviews. PFA v4 of the patchset, in which the tests
> are put into copy.sql (well, input/copy.source). This also adds tests
> for correctly reporting COPY ... FROM 'file'.

PFA v5, which fixes a failure in the pg_upgrade regression tests due
to incorrect usage of @abs_builddir@. I had the changes staged, but
forgot to add them to the patches.

Sorry for the noise.

-Matthias

Commits

Add some basic tests for progress reporting of COPY
- 15639d5e8f6f 14.0 landed
Add support for more progress reporting in COPY
- 9d2d45700928 14.0 landed
doc: Add backlinks to progress reporting documentation
- 8a8f4d8ede28 14.0 landed