Horton

Re: postgres_fdw: IMPORT FOREIGN SCHEMA ... LIMIT TO (partition)

Matthias van de Meent <boekewurm+postgres@gmail.com>

View thread View on postgr.es
From: Matthias van de Meent <boekewurm+postgres@gmail.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Amit Langote <amitlangote09@gmail.com>, Bernd Helmle <mailings@oopsware.de>, Matthias van de Meent <boekewurm+postgres@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Stephen Frost <sfrost@snowman.net>, Michael Paquier <michael@paquier.xyz>
Date: 2021-04-06T12:39:54Z
Lists: pgsql-hackers 
On Tue, 6 Apr 2021 at 14:29, Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>
> Thanks! So I applied all the changes that I suggested upthread to the patch.
> I also updated the comment as follows.
>
>                  * Import table data for partitions only when they are explicitly
> -                * specified in LIMIT TO clause. Otherwise ignore them and
> -                * only include the definitions of the root partitioned tables to
> -                * allow access to the complete remote data set locally in
> -                * the schema imported.
> +                * specified in LIMIT TO clause. Otherwise ignore them and only
> +                * include the definitions of the root partitioned tables to allow
> +                * access to the complete remote data set locally in the schema
> +                * imported.
>
> Attached is the updated version of the patch. Barring any objection,
> I'm thinking to commit this.

Thanks, this was on my to-do list for today, but you were faster.

No objections on my part, and thanks for picking this up.

With regards,

Matthias van de Meent

Commits

  1. postgres_fdw: Allow partitions specified in LIMIT TO to be imported.

  2. postgres_fdw: Teach IMPORT FOREIGN SCHEMA about partitioning.