Re: Reducing output size of nodeToString

Matthias van de Meent <boekewurm+postgres@gmail.com>

From: Matthias van de Meent <boekewurm+postgres@gmail.com>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andres Freund <andres@anarazel.de>, Michel Pelletier <pelletier.michel@gmail.com>

Date: 2024-02-22T15:07:55Z

Lists: pgsql-hackers

Attachments

v7-0004-gen_node_support.pl-Add-a-TypMod-type-for-signall.patch (application/octet-stream) patch v7-0004
v7-0003-gen_node_support.pl-Mark-location-fields-as-type-.patch (application/octet-stream) patch v7-0003
v7-0002-pg_node_tree-Don-t-store-query-text-locations-in-.patch (application/octet-stream) patch v7-0002
v7-0001-pg_node_tree-Omit-serialization-of-fields-with-de.patch (application/octet-stream) patch v7-0001
v7-0005-nodeToString-omit-serializing-NULL-datums-in-Cons.patch (application/octet-stream) patch v7-0005
v7-0007-gen_node_support.pl-Optimize-serialization-of-fie.patch (application/octet-stream) patch v7-0007
v7-0006-nodeToString-Apply-RLE-on-Bitmapset-and-numeric-L.patch (application/octet-stream) patch v7-0006
v7-0008-nodeToString-omit-serializing-0s-in-enum-typed-fi.patch (application/octet-stream) patch v7-0008

On Thu, 22 Feb 2024 at 13:37, Matthias van de Meent
<boekewurm+postgres@gmail.com> wrote:
>
> On Mon, 19 Feb 2024 at 14:19, Matthias van de Meent
> <boekewurm+postgres@gmail.com> wrote:
> > Attached the updated version of the patch on top of 5497daf3, which
> > incorporates this last round of feedback.
>
> Now attached rebased on top of 93db6cbd to fix conflicts with fbc93b8b
> and an issue in the previous patchset: I attached one too many v3-0001
> from a previous patch I worked on.

... and now with a fix for not overwriting newly deserialized location
attributes with -1, which breaks test output for
READ_WRITE_PARSE_PLAN_TREES installations. Again, no other significant
changes since the patch of last Monday.

Sorry for the noise,

-Matthias

Commits

Do not output actual value of location fields in node serialization by default
- d20d8fbd3e4d 17.0 landed
gen_node_support.pl: Mark location fields as type alias ParseLoc
- 605721f819f5 17.0 landed