Re: ECPG: WHENEVER statement with DO CONTINUE action
Vinayak <vinpokale@gmail.com>
From: Vinayak Pokale <vinpokale@gmail.com>
To: Michael Meskes <meskes@postgresql.org>
Cc: vinayak <Pokale_Vinayak_q3@lab.ntt.co.jp>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2017-06-10T03:23:33Z
Lists: pgsql-hackers
Thank you for your reply On Jun 9, 2017 5:39 PM, "Michael Meskes" <meskes@postgresql.org> wrote: > > Hi, > > > To develop the ECPG application more efficiently and improve > > portability, > > I would like to suggest one minor improvement "WHENEVER condition DO > > CONTINUE" support in ECPG. > > Oracle Pro*C supports WHENEVER statement with DO CONTINUE action.[1] > > > > EXEC SQL WHENEVER SQLERROR CONTINUE; > > is not same as > > EXEC SQL WHENEVER SQLERROR DO CONTINUE; > > > > The CONTINUE action instructs the client application to proceed to > > the next statement whereas DO CONTINUE action instructs the client > > application to emit a C continue statement and the flow of control > > return to the beginning of the enclosing loop. > > This did actual escape me. Thanks for bringing it to our attention and > fixing this missing functionality. > > > I have tried to implement it. Please check the attached patch. > > Please give me feedback. > > ... > > Could you please add a "DO CONTINUE" case to one of the test cases? Or > add a new one? We would need a test case IMO. > Yes I will add test case and send updated patch. Regards, Vinayak Pokale
Commits
-
Fix locale dependency in new ecpg test case.
- aae62278e167 11.0 landed