Horton

Re: Infinite Interval

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

View thread View on postgr.es
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: jian he <jian.universality@gmail.com>, Joseph Koshakow <koshy44@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, "Gregory Stark (as CFM)" <stark.cfm@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-11-09T07:15:01Z
Lists: pgsql-hackers

Attachments

On Wed, Nov 8, 2023 at 5:32 PM Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>
> On Wed, 8 Nov 2023 at 06:56, jian he <jian.universality@gmail.com> wrote:
> >
> > > On Tue, 7 Nov 2023 at 14:33, Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
> > >
> > > Ah, Windows Server didn't like that. Trying again with "INT64CONST(0)"
> > > instead of just "0" in interval_um().
> > >
> > I found this:
> > https://developercommunity.visualstudio.com/t/please-implement-integer-overflow-detection/409051
> > maybe related.
>
> Hmm, actually, this has revealed a bug in our 64-bit integer
> subtraction code, on platforms that don't have builtins or 128-bit
> integer support. I have created a new thread for that, since it's
> nothing to do with this patch.

Just to test whether that bug fix also fixes the failure seen with
this patchset, I am attaching the patchset including the patch with
the fix.

0001 - fix in other thread
0002 and 0003 are 0001 and 0002 in the previous patch set.

-- 
Best Wishes,
Ashutosh Bapat

Commits

  1. Support +/- infinity in the interval data type.

  2. Avoid integer overflow hazard in interval_time().

  3. Guard against overflow in make_interval().

  4. Fix minmax-multi on infinite date/timestamp values

  5. Optimize various aggregate deserialization functions, take 2

  6. Remove dead code in DecodeInterval()

  7. Accept "+infinity" in date and timestamp[tz] input.

  8. Fix overflow hazards in interval input and output conversions.