Re: SQL Property Graph Queries (SQL/PGQ)

Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>

From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: Junwang Zhao <zhjwpku@gmail.com>
Cc: Amit Langote <amitlangote09@gmail.com>, Vik Fearing <vik@postgresfriends.org>, Ajay Pal <ajay.pal.k@gmail.com>, Imran Zaheer <imran.zhir@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-03-12T04:31:38Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Fix some typos and make small stylistic improvements

  2. Cleanup users and roles in graph_table_rls test

  3. Dump labels in reproducible order

  4. SQL Property Graph Queries (SQL/PGQ)

  5. Factor out constructSetOpTargetlist() from transformSetOperationTree()

  6. Sort out table_open vs. relation_open in rewriter

  7. Rename grammar nonterminal to simplify reuse

  8. Make ecpg parse.pl more robust with braces

  9. Don't lock partitions pruned by initial pruning

  10. Remove pg_regex_collation

  11. Use auxv to check for CRC32 instructions on ARM.

  12. Fix inappropriate uses of atol()

  13. Remove unnecessary array object_classes[] in dependency.c

Thanks

On Tue, Mar 11, 2025 at 7:51 PM Junwang Zhao <zhjwpku@gmail.com> wrote:

>
> Here is a new version with Amit's fix and my trivial refactors.
>
> 0001-0010 is the same as Ashutosh's last email
> 0011 is Amit's fix of the crash in ExecCheckPermissions

I think that fix is correct and it fixes the crash. I need to think
more about it - especially whether there are more places where we are
missing RTE_GRAPH_TABLE. But will do that as time permits.

> 0012 is a trivial fix that remove the test with default collation, or
> it will fail CI, see[1]
> 0013-0015 are some trivial fix and refactor, feel free to incorporate
> or drop when you review them.
>
> [1]: https://api.cirrus-ci.com/v1/artifact/task/5290818690351104/testrun/build/testrun/regress/regress/regression.diffs
>

Thanks Junwang. I have added your patches to my local repository. Next
time I post an updated set, I will post it along with your patches.
Will merge them into the original patches as time permits.

-- 
Best Wishes,
Ashutosh Bapat