Re: [Patch]Add Graph* node support to expression_tree_mutator
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: SATYANARAYANA NARLAPURAM <satyanarlapuram@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-28T15:05:11Z
Lists: pgsql-hackers
Attachments
- v20260428-0001-Handle-nodes-that-may-appear-in-GraphPatte.patch (text/x-patch) patch v20260428-0001
On Thu, Apr 23, 2026 at 12:18 PM Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> wrote: > > > Why is MUTATE not called on GraphElementPattern::labelexpr and > GraphElementPattern::quantifier? The walker didn't WALK labelexpr and quantifier either. Given that labelexpr is a boolean expression it needs to be WALKed. quantifier is IntList which is ignored by other nodes as well when WALKing. But we need to copy quantifier in mutator otherwise the mutated expression will point to the same IntList as the original node. Other nodes also copy the OidLists and IntLists when mutating them. I have modified the test query to cover the label expression mutator. raw_expression_walker didn't cover labelexpr either. Added it there. The label expression at that stage contains ColumnRef and BoolExpr which are already covered by raw expression tree walker. -- Best Wishes, Ashutosh Bapat
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Handle nodes that may appear in GraphPattern expression trees
- dc9e7c9ed938 19 (unreleased) landed