Re: Fix typo in code comment
Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
From: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
To: Dewei Dai <daidewei1970@163.com>
Cc: Pgsql Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-08T15:24:23Z
Lists: pgsql-hackers
On Wed, Jan 7, 2026 at 4:50 PM Dewei Dai <daidewei1970@163.com> wrote: > > Hi hickers, > I fixed a comment error in origin.c. > The original comment was "* Replication origin consist out of a descriptive, user defined, externa..." > where I think "consist out of" is a typo and it should be "consists of". > You are right. LGTM. However, I find use of "consist of" itself not so accurate. consists of is used to denote relationship between whole and its parts. But what the sentence talks about is alternate representations of replication origin - long and short one. I think the sentence should be rewritten as "Replication origin has two interchangeable identifications: a descriptive .... ". What do you think? -- Best Wishes, Ashutosh Bapat
Commits
-
Fix typos in the code.
- 31ddbb38eeff 19 (unreleased) landed